Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exclude fastjson2 or hessian2 serialization dependencies #13441

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Nov 30, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ac2eaa) 69.47% compared to head (2e6d8ca) 69.45%.
Report is 9 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13441      +/-   ##
============================================
- Coverage     69.47%   69.45%   -0.03%     
  Complexity        2        2              
============================================
  Files          1653     1655       +2     
  Lines         71634    71696      +62     
  Branches      10270    10277       +7     
============================================
+ Hits          49768    49794      +26     
- Misses        17157    17187      +30     
- Partials       4709     4715       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlbumenJ added a commit to AlbumenJ/dubbo-samples that referenced this pull request Nov 30, 2023
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

56.1% 56.1% Coverage
0.0% 0.0% Duplication

@AlbumenJ
Copy link
Member Author

AlbumenJ commented Dec 4, 2023

@CrazyHZM @chickenlj PTAL

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 0d87966 into apache:3.2 Dec 4, 2023
14 checks passed
AlbumenJ added a commit to apache/dubbo-samples that referenced this pull request Dec 14, 2023
* Add test cases to verify apache/dubbo#13442

* Add test cases to verify apache/dubbo#13441

* Fix headers
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Jul 29, 2024
…che#13441)

* Support exclude fastjson2 or hessian2 serialization dependencies

* Fix style

* Support check

* Fix test cases

* lint

* Fix test cases

* Style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants